Add explanation to the doc of Hashtbl.create#13535
Merged
Merged
Conversation
|
What about |
MisterDA
force-pushed
the
hashtbl-create-doc
branch
from
c7a3912 to
bc1e7f0
Compare
Contributor
Author
Ooops, I cherry-picked Nick's draft and didn't check this. Fixed, thanks! |
Octachron
reviewed
Oct 10, 2024
| the table. The table grows as needed, so [n] is just an | ||
| initial guess. | ||
| (** [Hashtbl.create n] creates a new, empty hash table, with suggested | ||
| initial size [n]. For best results, [n] should be on the order of |
Member
There was a problem hiding this comment.
I am not sure if suggested is the right term here: the table is created with a concrete size. Maybe
[Hashtbl.create n] creates a new, empty hash table, with initial size greater or equal to the suggested size [n].
?
Contributor
Author
There was a problem hiding this comment.
Makes sense, I've applied your suggestion.
MisterDA
force-pushed
the
hashtbl-create-doc
branch
from
bc1e7f0 to
ab30a93
Compare
MisterDA
force-pushed
the
hashtbl-create-doc
branch
from
ab30a93 to
1069482
Compare
Majority view in the triage discussion of ocaml#13474 concluded that we should allow negative values but document that they are disregarded.
MisterDA
force-pushed
the
hashtbl-create-doc
branch
from
1069482 to
199caf4
Compare
Contributor
Author
|
sorry, the documentation text was off by one space. |
Octachron
added a commit
that referenced
this pull request
Oct 23, 2024
Add explanation to the doc of `Hashtbl.create` (cherry picked from commit 6c946cd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Majority view in the triage discussion of #13474 concluded that we should allow negative values but document that they are disregarded.
Fix #13469.
cc @NickBarnes