Update GitHub CI Ubuntu from 22.04 to 24.04. - #13665
Merged
Merged
Conversation
MisterDA
approved these changes
Dec 10, 2024
Contributor
|
For the record, I went with forcing CI to use 22.04 on my fork for now. |
shindere
approved these changes
Dec 16, 2024
Contributor
|
I'm unsure how to proceed with this PR. It does not pass CI at the @shym do you think we can force Ubuntu 24.04 on the main remo Unless @tmcgilchrist can so something about it but I believe he is |
Contributor
As 20.04 is still supported, I guess the 22.04 image will not be retired very soon. So I guess that a good way to let the dust settle on the present PR. |
Member
|
The two commits I just pushed should fix this (the whole lot can be squashed together at merge) |
Ideally everything should run on _whatever_ ubuntu-latest means at all times...
dra27
force-pushed
the
ubuntu_upgrade
branch
from
December 16, 2024 18:48
edf65e0 to
8257c32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's two parts to consider in this change. The first is that we should explicitly ask for Ubuntu 24.04 in CI, since GH is updating runners and which version of Ubuntu we get might change without warning.
The second part is better sanitisation of the LLDB output on Linux, which needs more consideration and probably re-writing to use Python API rather than running commands as the CLI. Using the Python API should allow better control over what gets printed out.