Repository navigation
Teach debugger scripts about variable number of domains - #13686
Merged
Merged
Conversation
NickBarnes
force-pushed
the
nick-debug-param-domains
branch
from
December 17, 2024 15:11
5da14bf to
fbf48e0
Compare
NickBarnes
force-pushed
the
nick-debug-param-domains
branch
from
December 17, 2024 15:13
fbf48e0 to
0de4054
Compare
gasche
approved these changes
Dec 17, 2024
gasche
left a comment
gasche
left a comment
Member
There was a problem hiding this comment.
This looks reasonable to me from a distance, thanks!
tmcgilchrist
approved these changes
Dec 17, 2024
tmcgilchrist
left a comment
tmcgilchrist
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me.
A small suggestion would be to add a real world usage example here or in the docstring of the Python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python scripts for GDB and LLDB to interpret OCaml values and search the OCaml heap have not kept up with recent runtime improvements, in particular #13272, so the
ocaml findcommand would crash. This fixes that regression.As part of this I added a
pointer_indexmethod to the value class for both LLDB and GDB (as the distinction betweena[n]for an arrayaandp[n]for a pointerpis meaningful in LLDB internals). Bothpointer_indexand the existingsubmethod would be better as__getitem__methods, but that's more work than was justified here.