Fix for inaccurate live blocks/words stats in compaction - #13774
Merged
Conversation
Contributor
Author
|
(I think Github decided my Changes entry meant closing the PR?) |
gasche
approved these changes
Feb 3, 2025
gasche
left a comment
gasche
left a comment
Member
There was a problem hiding this comment.
I reviewed this change in the process of trying to understand #13090, and I agree that it is correct.
(Nitpick: in the Changes entry, we could have a "reported by KC Sivaramakrishnan and Jan Midtgaard" mention, to credit the CI-watching and impressive reproduction work.)
Contributor
Author
Not a nitpick, they should definitely be credited. Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During compaction we effectively sweep garbage blocks in evacuated shared pools but do not correctly update stats. This change fixes #13090 .
With this the test in #13773 will also pass.