Standard library: rename Format.utf8_scalar_width to utf_8_scalar_width - #13794
Merged
Conversation
dra27
approved these changes
Feb 11, 2025
dbuenzli
approved these changes
Feb 11, 2025
The standard library consistently uses utf_8 and not utf8.
dra27
force-pushed
the
format_width_nomenclature_fix
branch
from
February 11, 2025 14:30
7c00836 to
c69f236
Compare
tmcgilchrist
pushed a commit
to tmcgilchrist/ocaml
that referenced
this pull request
Feb 17, 2025
The standard library consistently uses utf_8 and not utf8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nomenclature blunder sneaked inside #13570: the standard library only uses utf_8 and not utf8 for the unicode encoding, whereas my PR added a
utf8_scalar_width.This PR fixes this mistake while there is still time for consistency.