Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed position of last optional last semicolumn in sequence #1387

Merged
merged 4 commits into from Oct 1, 2017

Conversation

craff
Copy link
Contributor

@craff craff commented Oct 1, 2017

This fixes MPR#7619, removing just one word.
It treats position of optional last semicolmun in sequence as in list.

Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the change is correct and I can be convinced that it is desirable (in general having crisper locations is better, and apparently lists already behave that way).

Changes Outdated
@@ -565,6 +565,9 @@ Release branch for 4.06:
- GPR#1308: Only treat pure patterns as inactive
(Leo White, review by Alain Frisch and Gabriel Scherer)

- MPR#7619, GPR#1387: position of the optional last semi-column not included
in the position of the expression (same behavior than for lists)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same behavior "as"? You should also include an author credit line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is done.

@dra27 dra27 closed this Oct 1, 2017
@dra27 dra27 reopened this Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants