Repository navigation
document how to put alerts on all structure/signature items - #13924
Merged
Merged
Conversation
Octachron
reviewed
Apr 2, 2025
Octachron
reviewed
Apr 2, 2025
Octachron
reviewed
Apr 2, 2025
Octachron
reviewed
Apr 2, 2025
v-gb
force-pushed
the
alerts-doc
branch
2 times, most recently
from
April 2, 2025 11:50
73f60a6 to
17186a4
Compare
Octachron
reviewed
Apr 2, 2025
v-gb
force-pushed
the
alerts-doc
branch
2 times, most recently
from
April 2, 2025 13:02
f4db1ab to
21c7d49
Compare
Octachron
approved these changes
Apr 2, 2025
Octachron
left a comment
Octachron
left a comment
Member
There was a problem hiding this comment.
I think this is a great idea, thanks!
jmid
reviewed
Apr 2, 2025
For presumably marginally nicer display.
ghost
reviewed
Apr 2, 2025
… items
Personally, I had no idea it was possible to put an alert on a let binding
until I saw it mentioned on a github issue, because it's undocumented.
Ideally, warning 53 would teach users that write:
let x = 1 [@@deprecated]
to write:
let x [@deprecated] = 1
instead, but I'm only changing doc here. And arguably, the first form
could be interpreted as the second form, when the pattern contains a
single variable (and fail otherwise), as that's how alerts works for
all other binding constructs.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Personally, I had no idea it was possible to put an alert on a let binding until I saw it mentioned on a github issue, because it's undocumented. Ideally, warning 53 (unused attribute) would teach users that write:
to write:
instead, but I'm only changing doc here. And arguably, the first form could be interpreted as the second form, when the pattern contains a single variable (and fail otherwise), as that's how alerts works for all other binding constructs.