Renamed the internal representation of the no_alias_deps flag (into no_alias_deps) - #13972
Merged
Octachron merged 3 commits intoApr 22, 2025
Merged
Conversation
kit-ty-kate
reviewed
Apr 18, 2025
Co-authored-by: Kate <kit-ty-kate@outlook.com>
clementblaudeau
force-pushed
the
rename-internal-no-alias-deps
branch
from
April 18, 2025 13:42
ea7be6b to
4df884c
Compare
gasche
approved these changes
Apr 18, 2025
gasche
left a comment
gasche
left a comment
Member
There was a problem hiding this comment.
This is clearly fine, thanks! Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For historical reasons, the internal representation of the
-no-alias-depsflag was namedtransparent_modules. In preparation for transparent ascription, this PR proposes to rename it tono_alias_depsto avoid confusion with transparent signatures. The logic is not changed.It may affects direct users of
Clflags(ppx ?)