Repository navigation
error messages: also point tuple label mismatches - #14070
Merged
Merged
Conversation
gasche
approved these changes
Jun 4, 2025
gasche
left a comment
Member
There was a problem hiding this comment.
This is clearly reasonable. Approved. I think that backporting is reasonable, especially as the feature will be new in this release.
I thought a bit about why we didn't catch this during the review of the original implementation. I suppose that adding new raise_unexplained_for calls should be a review red/orange flag; to keep in mind for later.
Member
Author
|
Well, I found the issue by working on my plan to remove |
dra27
added a commit
that referenced
this pull request
Jun 5, 2025
error messages: also point tuple label mismatches (cherry picked from commit 688eabb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR aligns the error message for mismatched labels in labelled tuples with the one for
mismatched labels in labelled function arguments.
In other words, it adds after the current error message
a new line
to highlight that it is the labels
bandcthat are mismatched.This mirrors the current error message for labelled function argument:
I personally tend to consider that this is quite close to an error message bug, and we may want to backport the fix to 5.4 .