matching: fix some non-deterministic code generation - #14091
Merged
nojb merged 1 commit intoJul 9, 2025
Conversation
gasche
force-pushed
the
non-deterministic-matching-compilation-14088
branch
2 times, most recently
from
June 18, 2025 12:02
d5dd594 to
2ba5fca
Compare
lthls
approved these changes
Jun 30, 2025
Contributor
There was a problem hiding this comment.
Looks correct.
I was actually surprised to see this transformation here, as the native middle-end has to perform the reverse transformation anyway (i.e. place the failaction back into the constant/non-constant cases).
But I suspect bytecode compilation benefits from this, so I guess it makes sense to keep it.
gasche
force-pushed
the
non-deterministic-matching-compilation-14088
branch
from
June 30, 2025 08:10
2ba5fca to
aa44d44
Compare
fixes ocaml#14088 Reported-by: Christiano Calgano <cristianoc@users.noreply.github.com> Co-authored-by: Christiano Calgano <cristianoc@users.noreply.github.com>
gasche
force-pushed
the
non-deterministic-matching-compilation-14088
branch
from
June 30, 2025 08:12
aa44d44 to
b63340d
Compare
Member
Author
|
Thanks! I rebased. I put it in the 5.4 changelog as I intend to cherry-pick in the release branch. |
nojb
pushed a commit
that referenced
this pull request
Jul 9, 2025
Contributor
|
Cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14088 , following the rescript fix by @cristianoc