Increase the amount of data written to a pipe in a test#14116
Merged
Conversation
On some OSes, you need to write more than 1MB of data to a pipe before writes block, and read more than 64k to unblock them.
stedolan
force-pushed
the
fix-close-during-flush-test
branch
from
c0b179b to
bc529bf
Compare
dra27
approved these changes
Jun 30, 2025
dra27
left a comment
dra27
left a comment
Member
There was a problem hiding this comment.
I confirm the test now behaves correctly on ppc64 Linux!
dra27
pushed a commit
that referenced
this pull request
Jan 10, 2026
On some OSes, you need to write more than 1MB of data to a pipe before writes block, and read more than 64k to unblock them. (cherry picked from commit d7af01e)
raspbian-autopush
pushed a commit
to raspbian-packages/ocaml
that referenced
this pull request
Jan 24, 2026
On some OSes, you need to write more than 1MB of data to a pipe before writes block, and read more than 64k to unblock them. Bug-Debian: https://bugs.debian.org/1107773 Origin: ocaml/ocaml#14116 Gbp-Pq: Name Increase-the-amount-of-data-written-to-a-pipe-in-a-test.patch
raspbian-autopush
pushed a commit
to raspbian-packages/ocaml
that referenced
this pull request
Feb 26, 2026
On some OSes, you need to write more than 1MB of data to a pipe before writes block, and read more than 64k to unblock them. Bug-Debian: https://bugs.debian.org/1107773 Origin: ocaml/ocaml#14116 Gbp-Pq: Name Increase-the-amount-of-data-written-to-a-pipe-in-a-test.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new test in #14093 fails on ppc64 Linux. It turns out that the default pipe capacity on Linux is 16 pages, and on ppc64 a page is 64kB. So, you need to write a full megabyte to a pipe before it blocks, which is more than this test writes, causing it to fail. The fix is bumping the number.
(Thanks @dra27 for testing this on a ppc64 machine)