c++ support: move basic atomic type definitions to misc.h - #14139
Merged
Conversation
gasche
approved these changes
Jul 11, 2025
gasche
left a comment
gasche
left a comment
Member
There was a problem hiding this comment.
I agree that having this in misc.h makes sense. Approved.
It would be nice to have a more general macro to deal with the differences between C and C++ on atomic types. Currently there are two definitions in misc.h that are hidden to C++, just because they use _Atomic: fatal_error_hook and scan_roots_hook. (Could we simply have a TYPEDEF_ATOMIC(uintnat, atomic_uintnat) macro for example?)
Octachron
force-pushed
the
cpp_compatibility
branch
from
July 15, 2025 07:06
23d68aa to
2105aac
Compare
Octachron
added a commit
that referenced
this pull request
Jul 15, 2025
c++ support: move basic atomic type definitions to misc.h (cherry picked from commit e92e87f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #14101 by moving the definitions of
atomic_uintnatandatomic_intnatinmisc.h.Note that this only fixes the C++ uses of
misc.hwhenCAML_INTERNALSis defined which is not really supported.