Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give a non dummy location to warning 49 #1428

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@sliquister
Copy link
Contributor

sliquister commented Oct 13, 2017

$ cat a.ml
module B = B

Before:
$ ocamlc -no-alias-deps a.ml
File "none", line 1:
Warning 49: no cmi file was found in path for module B

After:
$ ocamlc -no-alias-deps a.ml
File "a.ml", line 1, characters 11-12:
Warning 49: no cmi file was found in path for module B

Valentin Gatien-Baron
give a non dummy location to warning 49
$ cat a.ml
module B = B

Before:
$ ocamlc -no-alias-deps a.ml
File "_none_", line 1:
Warning 49: no cmi file was found in path for module B

After:
$ ocamlc -no-alias-deps a.ml
File "a.ml", line 1, characters 11-12:
Warning 49: no cmi file was found in path for module B
@gasche

gasche approved these changes Oct 13, 2017

Copy link
Member

gasche left a comment

This looks like the right thing to do, will merge if CI passes.

@alainfrisch alainfrisch merged commit 0b09fb5 into ocaml:trunk Oct 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sliquister sliquister deleted the sliquister:warning-49-location branch Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.