Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spacetime runtime system compilation with -force-safe-string (MPR#7658) #1439

Merged
merged 2 commits into from Oct 20, 2017

Conversation

@mshinwell
Copy link
Contributor

mshinwell commented Oct 20, 2017

This patch fixes compilation of the Spacetime runtime when -force-safe-string has been specified to configure.

@mshinwell mshinwell added the bug label Oct 20, 2017
@gasche
gasche approved these changes Oct 20, 2017
@gasche

This comment has been minimized.

Copy link
Member

gasche commented Oct 20, 2017

You should feel free to merge and cherry-pick into 4.06. Would you include the name of the reporter, Christoph Spiel, in the Changes entry?

@mshinwell mshinwell merged commit 8d7d40e into ocaml:trunk Oct 20, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
mshinwell added a commit that referenced this pull request Oct 20, 2017
@shindere

This comment has been minimized.

Copy link
Contributor

shindere commented Oct 20, 2017

@gasche

This comment has been minimized.

Copy link
Member

gasche commented Oct 20, 2017

Yes, see CONTRIBUTING.md: Changelog:

The people that wrote the code should be credited of course, but also substantial code reviews or design advice, and the reporter of the bug (if applicable) or designer of the feature request (if novel).

I think it is more important in some cases than others. In the present case it seems likely to me that the issue would probably be present in the release if not for Christoph's testing and reporting work, and that certainly deserves credit.

@mshinwell: do you plan to also cherry-pick into 4.06? Otherwise I will do it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.