Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let rec: allow float array construction with -no-flat-float-array #1516

Merged
merged 2 commits into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@yallop
Copy link
Member

yallop commented Dec 6, 2017

On #1471, @gasche wrote:

[T]he test file testsuite/tests/typing-misc/pr6939.ml-noflat is broken. When -no-flat-float-array is set, the following definitions should be accepted as valid recursive definitions:

let rec x = [| x |]; 1.;;
let rec x = let u = [|y|] in 10. and y = 1.;;

and currently they are rejected.

This PR adds a check for -no-flat-float-array in the let-rec checking code so that the definitions are accepted and the failing pr6939.ml-noflat passes.

@gasche gasche merged commit db5e42a into ocaml:trunk Dec 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gasche

This comment has been minimized.

Copy link
Member

gasche commented Dec 7, 2017

Flawless pull request -- merged. Thanks!

@yallop yallop deleted the yallop:flat-float-array-let-rec branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.