Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the check_all_arches target no-op on 32-bit architectures #1571

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@xclerc
Copy link
Contributor

xclerc commented Jan 16, 2018

If the checks are actually run on a 32-bit architecture,
it means (among other things) that the 64-bit code emitters
cannot assume that nativeint is actually 64-bit.

@xclerc xclerc changed the title Make the `check_all_arches` target no-op on 32-bit architectures Make the check_all_arches target no-op on 32-bit architectures Jan 16, 2018

@xclerc xclerc referenced this pull request Jan 16, 2018

Open

Tweaks to amd64 emitter #1490

@damiendoligez

This comment has been minimized.

Copy link
Member

damiendoligez commented Feb 5, 2018

Why do you need to disable it? I tried check_all_arches on a 32-bit machine and it worked because it is only compiling those back-ends, not trying to run them. Ideally, it would only do the type-checking, but compiling is easier to set up.
[edit: nevermind, I just found the answer in #1490]

@damiendoligez
Copy link
Member

damiendoligez left a comment

If the test is false, you should display a message saying that the test was skipped. It won't change anything for Travis, but it's nicer to the user who launches the test by hand.

Other than that, LGTM

@xclerc

This comment has been minimized.

Copy link
Contributor Author

xclerc commented Feb 5, 2018

(...) it's nicer to the user who launches the test by hand.

Indeed.

@xclerc

This comment has been minimized.

Copy link
Contributor Author

xclerc commented Mar 20, 2018

Due to Travis issues I did not understand, I opened a roughly equivalent PR, #1671,
from a fresh branch and it fixed the problem(s).

@xclerc xclerc closed this Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.