Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix in testsuite: `make one DIR=` and `make parallel` #1574
433309b makes sure that
An error occasionally shows up when I test
I made a tentative fix 641d519 but I am not very sure it is definitely a correct change
Runhang Li (2018/01/22 19:43 +0000):
@gasche @shindere 433309b makes sure that `legacy` does not run ocamltest-based tests @shindere An error occasionally shows up when I test `make clean && make parallel` on my 24-core workstation: ``` Running tests from 'tests/ast-invariants' ... mkdir: cannot create directory ‘/aaa/bbb/projects/ocaml/testsuite/_ocamltest’: File exists Sysem command mkdir "/aaa/bbb/projects/ocaml/testsuite/_ocamltest" failed with status 1 ``` I made a tentative fix 641d519 but I am not very sure it is definitely a correct change
Wel mkdir -p is not portable so won't work on Windows. There is a plan to add mkdir and rmdir to OCaml's stdlib, that's on my todolist. On top of that we will be able to implement mkdir -p in OCaml, I think that's the long-term, clean way.
I tested the proposed change on the targets
For the first three (
added a commit
this pull request
Jan 28, 2018
Runhang Li (2018/01/30 16:55 -0800):
@gasche do we need to? I thought all commits will be squashed into one single commit when you press merge button.
Merge can be done in different ways, either squahsing or not squashing the commits. Some times it's better not to squash them, when they convey useful information.