Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect_test: print all the exceptions, even the unexpected ones #1619

Merged
merged 2 commits into from Feb 19, 2018

Conversation

Projects
None yet
2 participants
@trefis
Copy link
Contributor

trefis commented Feb 19, 2018

expect_test used to not print exceptions in the [%%expect {||}] blocks when the exception hasn't been registered with Location.register_error_of_exn.
This means that unexpected errors (assert false, fatal_error, etc) weren't caught and displayed in the expect block (only on stdout/stderr when running the test).

I'm not adding a test of this feature here but I'm using in another branch for which I'll soon create a PR.

Ping @diml.

@trefis trefis force-pushed the trefis:expect-exn branch from a16bb33 to 1b71ac1 Feb 19, 2018

@diml

diml approved these changes Feb 19, 2018

@trefis trefis merged commit 59bc6e1 into ocaml:trunk Feb 19, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@trefis trefis deleted the trefis:expect-exn branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.