Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reraise and raise_notrace are also nonexpansive #1628

Merged
merged 2 commits into from Mar 6, 2018

Conversation

Projects
None yet
3 participants
@lpw25
Copy link
Contributor

lpw25 commented Feb 23, 2018

#1142 made raise e a nonexpansive expression based on it being defined as the %raise primitive. This patch extends this treatment to the %reraise and %raise_notrace primitives.

@trefis

trefis approved these changes Feb 23, 2018

Copy link
Contributor

trefis left a comment

LGTM.

@alainfrisch

This comment has been minimized.

Copy link
Contributor

alainfrisch commented Feb 27, 2018

LGTM as well, but this deserves a Changes entry.

@lpw25 lpw25 force-pushed the lpw25:reraise-is-also-nonexpansive branch from f19d320 to 225e081 Mar 6, 2018

@lpw25

This comment has been minimized.

Copy link
Contributor Author

lpw25 commented Mar 6, 2018

Rebased, and added a changes entry. Now merging.

@lpw25

This comment has been minimized.

Copy link
Contributor Author

lpw25 commented Mar 6, 2018

...once the tests have rerun

@lpw25 lpw25 merged commit a1acfac into ocaml:trunk Mar 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.