Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPR#7745: Fix Unicode mismatch in win32graph #1629

Merged
merged 1 commit into from Feb 24, 2018

Conversation

Projects
None yet
3 participants
@dra27
Copy link
Contributor

dra27 commented Feb 23, 2018

The window class is created using RegisterClassA, which means that the default window procedure should be DefWindowProcA. See MSDN for explanation.

Fix Unicode mismatch in win32graph
The window class is created using RegisterClassA, which means that
the default window procedure should be DefWindowProcA.
@dra27

This comment has been minimized.

Copy link
Contributor Author

dra27 commented Feb 23, 2018

FWIW, this should be pushed to 4.06 as well.

@xavierleroy
Copy link
Contributor

xavierleroy left a comment

Looks good. Thanks!

@xavierleroy xavierleroy merged commit b2d0255 into ocaml:trunk Feb 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xavierleroy

This comment has been minimized.

Copy link
Contributor

xavierleroy commented Feb 24, 2018

Feel free to cherry-pick to 4.06 branch.

@fdopen

This comment has been minimized.

Copy link
Contributor

fdopen commented Feb 24, 2018

MPR#7745 , not MPR#7445

@dra27 dra27 changed the title MPR#7445: Fix Unicode mismatch in win32graph MPR#7745: Fix Unicode mismatch in win32graph Feb 24, 2018

@dra27

This comment has been minimized.

Copy link
Contributor Author

dra27 commented Feb 24, 2018

Thanks - silly eyesight :(

dra27 added a commit that referenced this pull request Feb 24, 2018

Fix Unicode mismatch in win32graph (#1629)
The window class is created using RegisterClassA, which means that
the default window procedure should be DefWindowProcA.

dra27 added a commit that referenced this pull request Feb 24, 2018

@dra27

This comment has been minimized.

Copy link
Contributor Author

dra27 commented Feb 24, 2018

Typo in Changes entry directly pushed in 01a4c30 and whole GPR cherry-picked to 4.06 in 7ac4212.

@dra27 dra27 deleted the dra27:fix-graphics branch Feb 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.