Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate -thread option #1653

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
3 participants
@nojb
Copy link
Contributor

nojb commented Mar 8, 2018

See MPR#7687.

@trefis

trefis approved these changes Mar 12, 2018

Copy link
Contributor

trefis left a comment

LGTM.

@mshinwell

This comment has been minimized.

Copy link
Contributor

mshinwell commented Mar 15, 2018

This looks fine to me, and @xavierleroy has approved the principle on the MPR. @nojb Please rebase then we can merge.

@nojb nojb force-pushed the nojb:deprecate_thread_option branch from 32d26c9 to 6c1bec4 Mar 15, 2018

@nojb

This comment has been minimized.

Copy link
Contributor Author

nojb commented Mar 15, 2018

Please rebase then we can merge.

Done.

@nojb nojb merged commit 3754131 into ocaml:trunk Mar 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nojb nojb deleted the nojb:deprecate_thread_option branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.