Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of cmx files in classic mode (flambda) #1665

Merged
merged 6 commits into from Apr 6, 2018

Conversation

Projects
None yet
5 participants
@xclerc
Copy link
Contributor

xclerc commented Mar 19, 2018

(Basically #1343 rebased on top of #1663, minus the part already in #1627
and the computation of reachable symbols to keep approximations only for
such symbols)

Reduces the size of cmx files by changing the types of closures and sets
of closures in export infos to newly-introduced approximations for these
entities and keeping the bodies of functions in classic mode iff they can be
inlined.

xclerc added some commits Mar 19, 2018

@xclerc

This comment has been minimized.

Copy link
Contributor Author

xclerc commented Mar 20, 2018

This PR was originally written @fyquah95, and reviewed by @lpw25 and myself.
My understanding is that we hence only need validation of the general approach
(typically from @chambart).

@chambart

This comment has been minimized.

Copy link
Contributor

chambart commented Apr 6, 2018

I'm ok. I made my remarks as a PR on this branch.

@chambart chambart added the approved label Apr 6, 2018

@damiendoligez

This comment has been minimized.

Copy link
Member

damiendoligez commented Apr 6, 2018

Now we need a rebase. @xclerc

@mshinwell

This comment has been minimized.

Copy link
Contributor

mshinwell commented Apr 6, 2018

Ack, this is being worked on today.

xclerc added some commits Apr 6, 2018

@damiendoligez
Copy link
Member

damiendoligez left a comment

Approval based on @chambart's review. Good to merge after CI completes.

@lpw25 lpw25 merged commit 4d5852d into ocaml:trunk Apr 6, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.