Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldebug: add a few commandline options #1667

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
2 participants
@shindere
Copy link
Contributor

shindere commented Mar 19, 2018

This commit adds the following options to ocamldebug:

  • -no-prompt: suppress all prompts
  • -no-version: do not print version at startup
  • -no-time: do not print times
  • -no-breakpoint: do not print message at breakpoint setup and removal
  • -topdirs-path: set path to the directory containing topdirs.cmi

The four first options allow to simplify the output of the debugger
and make it easier to test it. The last one makes it possible to
run the debugger from the source repository without having to install it
or creating an ad hoc compiler-libs directory as is currently done
by the test infrastructure.

@shindere shindere force-pushed the shindere:ocamldebug-options branch from 5d66b59 to d55b569 Mar 19, 2018

@damiendoligez
Copy link
Member

damiendoligez left a comment

Looks good except for two small remarks.

(Pos.get_desc event);
print_newline ()
if !Parameters.breakpoint
then begin

This comment has been minimized.

@damiendoligez

damiendoligez Mar 19, 2018

Member

To be consistent with the codebase, you should put the then begin at the end of the previous line.

" Suppress all prompts";
"-no-time", Arg.Clear Parameters.time,
" Do not print times";
"-no-breakpoint", Arg.Clear Parameters.breakpoint,

This comment has been minimized.

@damiendoligez

damiendoligez Mar 19, 2018

Member

Could you change the option to -no-breakpoint-message ? I think it would be less misleading.

ocamldebug: add a few commandline options
This commit adds the following options to ocamldebug:
 * -no-prompt: suppress all prompts
 * -no-version: do not print version at startup
 * -no-time: do not print times
 * -no-breakpoint: do not print message at breakpoint setup and removal
 * -topdirs-path: set path to the directory containing topdirs.cmi

@shindere shindere force-pushed the shindere:ocamldebug-options branch from d55b569 to 23a6845 Mar 20, 2018

@shindere shindere merged commit 23a6845 into ocaml:trunk Mar 20, 2018

0 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@shindere

This comment has been minimized.

Copy link
Contributor Author

shindere commented Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.