Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Float.pi #1674

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
None yet
3 participants
@Chris00
Copy link
Member

Chris00 commented Mar 21, 2018

@Chris00 Chris00 referenced this pull request Mar 21, 2018

Closed

Add Pervasives.pi #964

@Chris00 Chris00 force-pushed the Chris00:pi branch 2 times, most recently from 9715c4c to f22d847 Mar 23, 2018

@damiendoligez
Copy link
Member

damiendoligez left a comment

I checked the value against http://piday.org/million and https://en.wikipedia.org/wiki/Pi, it's very probably the right one.

@nojb

This comment has been minimized.

Copy link
Contributor

nojb commented Mar 29, 2018

@Chris00 If you can add Damiel Doligez as a reviewer in the Changes file, we can merge this.

@Chris00 Chris00 force-pushed the Chris00:pi branch from f22d847 to 9f0f710 Mar 29, 2018

@Chris00

This comment has been minimized.

Copy link
Member Author

Chris00 commented Mar 29, 2018

Done.

@nojb nojb merged commit 2197ec6 into ocaml:trunk Mar 29, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@nojb

This comment has been minimized.

Copy link
Contributor

nojb commented Mar 29, 2018

Thanks!

@Chris00 Chris00 deleted the Chris00:pi branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.