Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: remove Pbittest #1679

Merged
merged 2 commits into from Apr 6, 2018

Conversation

Projects
None yet
5 participants
@hhugo
Copy link
Contributor

hhugo commented Mar 27, 2018

Pbittest seems to be unused.
I did not remove caml_bitvect_test has it requires a bootstrap.

@gasche

This comment has been minimized.

Copy link
Member

gasche commented Mar 28, 2018

cc @maranget : this primitive was used in pattern-matching compilation

@xclerc

This comment has been minimized.

Copy link
Contributor

xclerc commented Mar 28, 2018

(Perhaps, we should first assess whether the primitive could be
useful for things like #1334.)

@mshinwell

This comment has been minimized.

Copy link
Contributor

mshinwell commented Mar 28, 2018

This looks fine subject to @maranget not objecting. I can do the bootstrap.

@maranget

This comment has been minimized.

Copy link
Contributor

maranget commented Mar 29, 2018

No objection.

@hhugo hhugo force-pushed the hhugo:cleanup-bittest branch from ce3ea8e to 30ed63c Apr 5, 2018

@mshinwell mshinwell merged commit de6b8af into ocaml:trunk Apr 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mshinwell

This comment has been minimized.

Copy link
Contributor

mshinwell commented Apr 6, 2018

The bootstrap commit to remove caml_bitvect_test is 6eb19307fde3f5c64d12fde615038f4e3e76c627

@hhugo hhugo deleted the hhugo:cleanup-bittest branch May 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.