Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn flambda invariants checks off by default #1686

Merged
merged 6 commits into from Apr 6, 2018

Conversation

Projects
None yet
3 participants
@chambart
Copy link
Contributor

chambart commented Mar 30, 2018

I think that flambda is mature enough for this change. Now it doesn't seem to catch enough bugs in the wild to justify the increased compilation time.

This change includes a new compile time option to turn the checks on, and a configure option to change the default. The configure option is used to keep those checks enabled for travis. It might be a good idea to keep them on also for Inria's CI. @damiendoligez What do I need to do for that ?

If this goes in 4.07, we might want to merge that after the beta.

@shindere

This comment has been minimized.

Copy link
Contributor

shindere commented Mar 30, 2018

@chambart chambart force-pushed the chambart:default_no_flambda_invariants branch from d806cf1 to 0fe1006 Mar 30, 2018

@chambart

This comment has been minimized.

Copy link
Contributor Author

chambart commented Mar 30, 2018

@shindere, Is 0fe1006 the right way to do that ?

@shindere

This comment has been minimized.

Copy link
Contributor

shindere commented Mar 30, 2018

@mshinwell

This comment has been minimized.

Copy link
Contributor

mshinwell commented Apr 6, 2018

I've reviewed the whole of this and it looks correct. I don't think we need to precheck this one, so merging now.

@mshinwell mshinwell merged commit 0a42259 into ocaml:trunk Apr 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.