Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlobjinfo: add the -no-crc command-line option #1695

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
3 participants
@shindere
Copy link
Contributor

shindere commented Apr 5, 2018

When this option is used, the CRCs of ipmported interfaces are not
displayed. This is useful e.g. in the testsuite.

@dra27

dra27 approved these changes Apr 5, 2018

Copy link
Contributor

dra27 left a comment

Great idea - it'll be good to use it to eliminate those horrible sed transforms in the testsuite!

@@ -323,6 +328,7 @@ let dump_obj filename =
let arg_list = [
"-no-approx", Arg.Set no_approx, " Do not print module approximation information";
"-no-code", Arg.Set no_code, " Do not print code from exported flambda functions";
"-no-crc", Arg.Set no_crc, " Do not print CRC of imported interfaces";

This comment has been minimized.

@dra27

dra27 Apr 5, 2018

Contributor

Tiniest nit: "the CRC"

@shindere

This comment has been minimized.

Copy link
Contributor Author

shindere commented Apr 5, 2018

@gasche

gasche approved these changes Apr 5, 2018

ocamlobjinfo: add the -no-crc command-line option
When this option is used, the CRCs of ipmported interfaces are not
displayed. This is useful e.g. in the testsuite.

@shindere shindere force-pushed the shindere:ocamlobjinfo-no-crc branch from cdd3c36 to 90ca603 Apr 5, 2018

@shindere shindere closed this Apr 5, 2018

@shindere shindere deleted the shindere:ocamlobjinfo-no-crc branch Apr 5, 2018

@shindere

This comment has been minimized.

Copy link
Contributor Author

shindere commented Apr 5, 2018

@shindere

This comment has been minimized.

Copy link
Contributor Author

shindere commented Apr 5, 2018

I had to slightly change this feature to be in tune with the real needs of
the testsuite, sorry. See commit c20b261.

@dra27

This comment has been minimized.

Copy link
Contributor

dra27 commented Apr 5, 2018

All good!

@shindere

This comment has been minimized.

Copy link
Contributor Author

shindere commented Apr 5, 2018

@shindere

This comment has been minimized.

Copy link
Contributor Author

shindere commented Apr 5, 2018

See also commit e84965c :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.