Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Make Ident.t abstract and immutable. #1704
The initial version of this patch made Ident.t abstract to avoid exposing the mutability, but I realized that the mutability was not really used anywhere anymore (it used to be important for the toplevel), so I made it immutable as well.
This is useful for compiler forks that play tricks with Idents, in particular the one that have additional flags like cough Eliom cough and MetaOCaml.
This change is technically breaking. For example, js_of_ocaml's toplevel used to access idents's fields directly (this is not the case anymore). I'm not sure how much it is used otherwise (I guess not much).
@mshinwell Even then, merge commits in feature branches make the commit history very hard to read and are often unnecessary. For such small patchset, rebasing is both easier and produces a clean history.