Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Compenv.implicit_modules #1711

Merged
merged 3 commits into from Apr 13, 2018

Conversation

Projects
None yet
3 participants
@nojb
Copy link
Contributor

commented Apr 9, 2018

Seems to be dead code.

@mshinwell

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2018

@lpw25 and I looked at this. Originally there was support for "open" in OCAMLPARAM, but for some reason it was removed (possibly accidentally?) in 1823936. It used to use implicit_modules.

So it looks like the implicit_modules code should indeed be removed, but the following hunk should be resurrected in compenv.ml, changing implicit_modules for open_modules:

@@ -240,7 +167,6 @@ let read_OCAMLPARAM position =
 
       | "pp" -> preprocessor := Some v
       | "runtime-variant" -> runtime_variant := v
-      | "open" -> implicit_modules := Misc.split v ','
       | "cc" -> c_compiler := Some v
 
       (* assembly sources *)
@gasche

This comment has been minimized.

Copy link
Member

commented Apr 10, 2018

@nojb nojb force-pushed the nojb:dead_code branch from 667ad46 to e4cc7db Apr 11, 2018

@nojb nojb force-pushed the nojb:dead_code branch from e4cc7db to f2de4da Apr 11, 2018

@nojb nojb force-pushed the nojb:dead_code branch from f2de4da to e8d93a1 Apr 11, 2018

@mshinwell

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2018

@nojb Please add a Changes entry, since we've added an OCAMLPARAM option, then OK to merge.

@nojb nojb merged commit 16656ec into ocaml:trunk Apr 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nojb nojb deleted the nojb:dead_code branch Apr 13, 2018

damiendoligez added a commit that referenced this pull request Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.