Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Stream.junk on channel streams #1714
A bug happens when doing
Rather, we should refill the buffer if needed in
gasche left a comment •
I believe that the fix is correct, modulo a minor comment.
(I'm positively surprised by how much cleaner the Stream codebase is than the last time I looked at it. Thanks @chambart!)
(We could now use inline records to optimize the
@nojb feel free to cherry-pick in 4.07.
(Cherry-picking a multi-commit change is kind of tricky, good luck with git. I can do it myself if you wish. My approach is to create a copy of the branch with
By the way, if your version of
$ git checkout 4.07 $ git cherry-pick trunk^1..fix_stream_bug