Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
debugger: avoid off-by-one overflow in debugger socket path #1753
Modern gcc have a
Rather than silently truncate the path, this patch raises an exception if the path is too long, and also fixes the off-by-one in the strncpy invocation.
This (along with #1752) fix compilation on Fedora 28 with trunk.
Anil Madhavapeddy (2018/05/02 04:58 -0700):
@shindere yes, it would be good to add some more of these options to CFLAGS, but I'd rather do that as a separate PR. A quick glance through gcc8's docs show quite a lot of new warnings, and clang also has a different set.
Sure, it can be done in a separate PR. Thanks!