Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make string_of_float and float_of_string locale-independent #1803

Merged
merged 6 commits into from Jun 1, 2018

Conversation

Projects
None yet
4 participants
@ygrek
Copy link
Contributor

commented May 27, 2018

(previously known as #1185 and #1682)

@damiendoligez I implemented your suggestion as in
#1682 (comment)
except it includes both xlocale.h and locale.h if they are available (should be more robust this way)

Tested only on linux, counting on CI to test on other platforms

@gasche

This comment has been minimized.

Copy link
Member

commented May 27, 2018

(For CI experts: I tried to do a precheck run of this PR at precheck/101, but it appears that all builds were "skipped" and I have no idea why.)

@damiendoligez

This comment has been minimized.

Copy link
Member

commented May 31, 2018

@gasche, no idea why your precheck failed. I've relaunched it and it seems to be doing some actual work.

cc @shindere

@shindere

This comment has been minimized.

Copy link
Contributor

commented May 31, 2018

@shindere

This comment has been minimized.

Copy link
Contributor

commented May 31, 2018

@gasche

This comment has been minimized.

Copy link
Member

commented Jun 1, 2018

The new precheck runs give the same results as trunk (in particular the macos instances work fine; msvc/mingw have issues that seem unrelated), so I consider that this PR is now correct. I will resolve the Changes conflict and merge in trunk.

@gasche gasche force-pushed the ygrek:uselocale branch from 0571f70 to 1739e4e Jun 1, 2018

@gasche gasche merged commit b00b96b into ocaml:trunk Jun 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ygrek ygrek deleted the ygrek:uselocale branch Jun 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.