Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Scanf.format_from_string when argument contains character that need escaping #1820

Merged
merged 3 commits into from Jun 7, 2018

Conversation

Projects
None yet
2 participants
@nojb
Copy link
Contributor

commented Jun 6, 2018

See MPR#7799.

Fix consists in replacing the (incorrect) implementation of string escaping in Scanf.string_to_String by String.escaped.

@gasche

gasche approved these changes Jun 6, 2018

Copy link
Member

left a comment

Thanks!

@nojb

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2018

Should we get this into 4.07 ?

@gasche

This comment has been minimized.

Copy link
Member

commented Jun 6, 2018

Yes if you do the work of cherry-picking and moving the Changes entry to the right place on both sides. But personally I don't think this is worth the trouble -- this function is obscure anyway.

@nojb

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2018

OK, let's leave it in trunk only then.

@nojb nojb force-pushed the nojb:mpr7799 branch from ac0a9ed to 582e8ef Jun 6, 2018

@nojb nojb merged commit ac3ed00 into ocaml:trunk Jun 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nojb nojb deleted the nojb:mpr7799 branch Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.