Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow non-val payload types in CMM Ccatch #1833
This patch adds explicit type annotations for Ccatch payloads in the CMM
(Now with the x86 build problem fixed, and rebased on top of the most recent commit...)
While CMM generated from OCaml source will always generate payloads of type
The design of the patch is as follows:
Since all OCaml code will use
I did not review the PR yet, but I fully support the approach. I did a similar experiment ( trunk...alainfrisch:unbox_across_jumps ) also including some logic to actually unbox floats (and boxed integers) across static jumps, but it makes sense to include the infrastructure first before such heuristics.
Great! I'm glad you agree with the approach. I think we're coming at this from different angles, which is promising since it seems to suggest the infrastructure would be useful for other purposes too.
The Travis seems to have failed on the changelog modification test which I'll modify when appropriate, but passed everything else.