Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR#1856 #1869

Merged
merged 2 commits into from Jun 29, 2018

Conversation

Projects
None yet
4 participants
@xclerc
Copy link
Contributor

commented Jun 29, 2018

This PR fixes an embarrassing mistake in PR#1856:
the -fdebug-prefix-map command-line switch should
be passed to the C compiler iff it supports it.

In the previous version, only one of the two uses was
guarded by a condition over Config.c_has_debug_prefix_map.

@shindere

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2018

@xclerc

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2018

(Thanks for the approval!)

Well, I am not sure this PR deserves an entry in
the change log; I mean, it only fixes a stupid mistake
that should have been avoided in the first place...

@gasche gasche merged commit 284203c into ocaml:trunk Jun 29, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@gasche

This comment has been minimized.

Copy link
Member

commented Jun 29, 2018

I edited the GPR#1856 change as suggested, and merged. Thanks to you both for the quick reaction, and sorry for not catching the problem earlier.

@shindere

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2018

@damiendoligez

This comment has been minimized.

Copy link
Member

commented Jun 29, 2018

Yes. Sometimes I grep a PR number in Changes It's better to include all relevant PRs in the Changes entry.

@xclerc xclerc referenced this pull request Nov 13, 2018

Closed

Reproducible builds #714

@vicuna vicuna referenced this pull request Mar 14, 2019

Closed

bug #1869 still in pl2 #8371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.