Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add check-typo compatibility to recent GPRs #1874
This GPR should restore the CI to blue/green.
David Allsopp (2018/07/01 03:40 -0700):
Marvellous - CI back in the blue...
Thanks a lot! Perhaps, next time, if you merge something that you know will break the CI, can you please post a comment to let people know you are going to deal with the breakage? Cause I started to fix it before I saw your PR. Thanks!
David Allsopp (2018/07/01 04:16 -0700):
Sorry @shindere - that's part of the reason I did it on a Sunday! Too many of us keenly hacking at the weekend.
Understood :) The thing is, fi CI at Inria fails on a week-end, even if I amnot actually hacking, I will most likely spend at least sometime trying to figure out what's going on and perhaps even try to fix it, because I really don't like CI being broken. And I didn't know you were on CI notifications (actually I knew but forgot) and I ddin't know either you knew a few recently merged PRs did alter your great linting work.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.