Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
MPR#7815: major GC crash with first-fit policy #1896
Jul 12, 2018
This clearly fixes the buffer overflow, but I'm afraid I don't understand this code well enough to be able to give a less superficial review!
In particular, in the new code the loop can now exit having found neither the
If you carefully follow the logic in lines 357--375 you'll see that we don't need to find more than
Got it, thanks.
If I understand this correctly, we're updating
truncated to at most FLP_MAX elements.
I read through the logic on lines 357--375, and I think it can be simplified slightly because of the new loop condition. Since the new condition includes