Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPR#7814: fix non-prefixed symbol names in debug and instrumented runtimes #1900

Merged
merged 3 commits into from Jul 13, 2018

Conversation

Projects
None yet
2 participants
@damiendoligez
Copy link
Member

commented Jul 12, 2018

Follow Xavier's advice and make names_of_instructions static.
Rename auxiliary functions of the instrumented runtime to lowercase names.
Also rename the struct declaration to lowercase for consistency.

See also: https://caml.inria.fr/mantis/view.php?id=7814

@xavierleroy
Copy link
Contributor

left a comment

Looks good!

@damiendoligez damiendoligez force-pushed the damiendoligez:fix-mpr7814 branch from 8f5f9f4 to 4f6e0dd Jul 13, 2018

@damiendoligez damiendoligez merged commit b6cf38d into ocaml:trunk Jul 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.