Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPR#7824 #1914

Merged
merged 3 commits into from Jul 19, 2018

Conversation

Projects
None yet
2 participants
@trefis
Copy link
Contributor

commented Jul 18, 2018

@trefis trefis requested a review from garrigue Jul 18, 2018

@garrigue
Copy link
Contributor

left a comment

Calling filter_row_fields here cannot hurt, and it looks correct.

@trefis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2018

Thanks for the review.
Once merged, should this also be cherry-picked on the 4.07 branch?

@garrigue

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2018

Indeed. This is all the point of keeping a bug fixing branch.

@trefis trefis force-pushed the trefis:subtype_row branch from 53ac77d to dceea74 Jul 19, 2018

@trefis trefis merged commit b1bc504 into ocaml:trunk Jul 19, 2018

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

trefis added a commit that referenced this pull request Jul 19, 2018

@trefis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2018

I moved the changelog entry to the 4.07 section, merged and cherry-picked on the 4.07 branch.

@trefis trefis deleted the trefis:subtype_row branch Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.