Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unix.fsync on Windows: retrieve fd outside blocking section #1949

Merged
merged 2 commits into from Aug 1, 2018

Conversation

Projects
None yet
2 participants
@nojb
Copy link
Contributor

commented Jul 31, 2018

Fixes a bug spotted by @ygrek: win_CRT_fd_of_filedescr needs to be called outside blocking section because the argument is a heap block.

@nojb nojb referenced this pull request Jul 31, 2018

Merged

Unix fsync #1839

@gasche

gasche approved these changes Jul 31, 2018

Copy link
Member

left a comment

I reviewed that the change is safe -- I can't tell that it suffices for the overall code to be correct.

(Editing the Unix.fsync Changes entry to credit @nojb and @ygrek would be nice.)

@nojb nojb force-pushed the nojb:unix_fsync_windows_fix_ygrek branch from 295fb00 to 13a3ea7 Jul 31, 2018

@nojb nojb merged commit e9fc13e into ocaml:trunk Aug 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nojb nojb deleted the nojb:unix_fsync_windows_fix_ygrek branch Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.