Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stack.{top_opt,pop_opt} and Queue.{peek_opt,take_opt} #1957

Merged
merged 2 commits into from Aug 2, 2018

Conversation

Projects
None yet
3 participants
@keleshev
Copy link
Contributor

commented Aug 1, 2018

See #1948 for related discussion.

The original PR #885 was used as an inspiration for decisions, such as:

  • Implementation of _opt funcitons is duplicated, instead of delegating to non-opt versions.
  • Location and style of unit tests.
  • Documentation style.
@nojb

nojb approved these changes Aug 2, 2018

Copy link
Contributor

left a comment

Thanks for the nice PR, LGTM.

@gasche

gasche approved these changes Aug 2, 2018

@nojb nojb merged commit c6cb7df into ocaml:trunk Aug 2, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nojb

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2018

Thanks!

@keleshev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2018

@nojb @gasche thanks for your reviews and timely responses.

@keleshev keleshev deleted the keleshev:queue-stack-opt branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.