Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for TERM=norepeat when displaying errors #1979

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
5 participants
@Armael
Copy link
Member

commented Aug 9, 2018

Another follow-up of #1952 that was discussed during the review. TERM=norepeat was used by the manual build setup, but is not needed anymore since #1863 switched to compiler-libs instead of parsing the compiler output.
Removing it simplifies the error printing code, getting rid of one seemingly unused code path we have to think about when refactoring this part of the code.

I added a Changes entry and marked the change as potentially breaking, since people might in theory use the feature in the wild, even though it's unlikely, I would say.

@gasche

gasche approved these changes Aug 9, 2018

Copy link
Member

left a comment

Good to go if the CI passes. (I don't think anyone was using the feature besides the manual.)

@Armael Armael force-pushed the Armael:remove_norepeat branch from 978a62f to 347ee52 Aug 9, 2018

@Octachron

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2018

I am in favor of the removal and the feature was undocumented but a quick search shows at least one use case in oloop which is still distributed on opam but only compatible with OCaml<4.03.

@gasche

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

(cc @Chris00, in case you have an opinion)

@Chris00

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

Thanks for letting me know. The removal is fine with me.

Remove support for TERM=norepeat when displaying errors
This was used to build the manual, but is not needed anymore since GPR#1863

@Armael Armael force-pushed the Armael:remove_norepeat branch from 347ee52 to 0cc5263 Aug 14, 2018

@shindere shindere merged commit 49b104f into ocaml:trunk Aug 14, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.