Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldoc: expand support for "include module type of" #2000

Merged
merged 2 commits into from Aug 22, 2018

Conversation

Projects
None yet
2 participants
@Octachron
Copy link
Contributor

commented Aug 22, 2018

This PR extends the adhoc support in ocamldoc for

include module type of M

to also include the expanded version

include module type of struct include M end

See #1605 for an use case.

@diml

diml approved these changes Aug 22, 2018

Copy link
Member

left a comment

I'm not an ocamldoc expert, however the change looks straightforward and the resulting html looks correct.

@diml

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

@Octachron I think we can merge this after adding a changelog entry

@Octachron Octachron force-pushed the Octachron:ocamldoc_include_module_type_of branch from 60c7bca to 644927f Aug 22, 2018

@diml diml merged commit 070541b into ocaml:trunk Aug 22, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nojb nojb referenced this pull request Aug 23, 2018

Merged

Deprecate Pervasives #1605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.