Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Emacs: Use built-in detection of comments #2040
This fixes https://caml.inria.fr/mantis/view.php?id=7844 where we crashed if we found text that looked like a definition inside a comment.
This is also faster and simpler. Emacs does handle nested comments correctly, but the comments worrying about this were written in 1996 when that may have been true.
It would be nice to have someone that knows about the Emacs mode to give a look at this proposed patch. @Chris00, would you be able to comment on whether the change looks right to you? It would also affect Tuareg.
There's one problem I found with this PR, prefixing a variable with
module rec Foo : FOO = struct and in_hello = let b in in_hello (* error *)