Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename [Mach.Ialloc] record field from "words" to "bytes" #2074

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@mshinwell
Copy link
Contributor

commented Sep 27, 2018

I realised during review of GPR#1917 that I had misnamed the record field called words in the Mach.Ialloc record. This patch should fix that.

I removed an assert in Selectgen as I think it was misleading, and the checked value isn't used (and probably always zero). I didn't find any other logic errors as a result of this mistake.

@mshinwell mshinwell added the bug label Sep 27, 2018

@mshinwell mshinwell added this to the 4.08 milestone Sep 27, 2018

@diml

diml approved these changes Oct 2, 2018

Copy link
Member

left a comment

This looks correct. It would probably help if functions such as size_expr had a more explicit name, such as size_expr_in_bytes.

@mshinwell mshinwell force-pushed the mshinwell:fix_ialloc_words branch from d7147fa to 8320564 Oct 2, 2018

@mshinwell mshinwell merged commit dae65da into ocaml:trunk Oct 2, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

mshinwell added a commit to mshinwell/ocaml that referenced this pull request Oct 3, 2018

damiendoligez added a commit to damiendoligez/ocaml that referenced this pull request Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.