Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards autoconf #4: Remove the dl_needs_underscore feature #2115

Merged
merged 1 commit into from Oct 25, 2018

Conversation

@shindere
Copy link
Contributor

commented Oct 23, 2018

This belongs to the GPR series #2044, #2059, #2113.

This feature could not be enabled anyway so this PR removes it.

The change is submitted in a separate PR just to highlight it and in
an attempt to make the "final" autoconf PR smaller in terms of
what it changes at the "functional" level.

Remove the dl_needs_underscore feature
This feature could not be enabled anyway
@damiendoligez
Copy link
Member

left a comment

This PR is just removing dead code. Approved.

@damiendoligez

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

I've restarted the CI job that got stuck.

@shindere shindere merged commit 6eea292 into ocaml:trunk Oct 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shindere

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2018

@shindere shindere deleted the shindere:towards-autoconf-4 branch Oct 25, 2018

damiendoligez added a commit to damiendoligez/ocaml that referenced this pull request Nov 5, 2018

Remove the dl_needs_underscore feature (ocaml#2115)
This feature could not be enabled anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.