Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old GC-triggering heuristic #2144

Merged
merged 3 commits into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@damiendoligez
Copy link
Member

commented Nov 12, 2018

As pointed out in MPR#7676 and #1738 (comment), this old GC heuristic doesn't really make sense.

AFAICT, the idea was to avoid an accumulation of "debt" in caml_extra_heap_resources when lots of resources are allocated between two major slices, with very little allocations in the minor heap. The danger is to have a large major slice with a large latency.

If this problem ever arises in practice, it can be mitigated by the GC smoothing introduced by #297.

@alainfrisch
Copy link
Contributor

left a comment

LGTM.

(Do you think this could explain in part MPR#6294, or other bad behavior observed in the wild?)

@damiendoligez

This comment has been minimized.

Copy link
Member Author

commented Nov 12, 2018

I need to add a changelog entry.

@damiendoligez

This comment has been minimized.

Copy link
Member Author

commented Nov 12, 2018

(Do you think this could explain in part MPR#6294, or other bad behavior observed in the wild?)

I doubt it. The real problem is the old API forcing libraries to choose constants a priori while programs have widely varying usage.

@damiendoligez damiendoligez self-assigned this Nov 12, 2018

@damiendoligez damiendoligez merged commit c1554c4 into ocaml:trunk Nov 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@damiendoligez damiendoligez deleted the damiendoligez:remove-gc-heuristic branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.