Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate the mutability of Gc.control record fields #2145

Merged

Conversation

Projects
None yet
3 participants
@damiendoligez
Copy link
Member

commented Nov 12, 2018

Follow-up to #297 (comment). I'll add a Changes entry.

Show resolved Hide resolved stdlib/gc.mli Outdated
@alainfrisch
Copy link
Contributor

left a comment

LGTM, except I would prefer documenting a syntax without the local-open.

@damiendoligez damiendoligez self-assigned this Nov 12, 2018

@damiendoligez

This comment has been minimized.

Copy link
Member Author

commented Nov 13, 2018

As far as I can tell, Appveyor failed because of a time-out. Since this is a low-risk change I'll merge rather than relaunch all the tests.

@damiendoligez damiendoligez merged commit 9e5e37c into ocaml:trunk Nov 13, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.