Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little parser cleanup #2174

merged 11 commits into from Dec 3, 2018


None yet
3 participants
Copy link

commented Nov 29, 2018

Here a small set of changes that do not make any observable difference.

fpottier added some commits Nov 29, 2018

Clean up `record_expr` and rename it `record_expr_content`.
Also rename `lbl_expr` to `record_expr_field`.
More renamings, for consistency.
Rename `lbl_pattern_list` to `record_pat_content`.
Rename `lbl_pattern` to `record_pat_field`.
Rename `field_expr_list` to `object_expr_content`.
Rename `field_expr` to `object_expr_field`.
More sharing in `object_expr_field`.
Also change `exp_of_label` and `pat_of_label` so they are easier to call.

This comment has been minimized.

Copy link

commented Nov 29, 2018

(You're missing a Changes entry -- I think you can simply add the PR to the existing entry for the Menhir parser)

fpottier added some commits Nov 29, 2018


This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2018

Thanks Armaël!


gasche approved these changes Dec 3, 2018

@gasche gasche merged commit d08ec1c into ocaml:trunk Dec 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.