Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make caml-mode an independent project #2182

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
6 participants
@Chris00
Copy link
Member

commented Dec 4, 2018

This was requested by Gabriel Scherer:
#2078 (comment)
Independent version: https://github.com/Chris00/caml-mode

@xavierleroy

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2018

I'm always in favor of moving stuff out of the core distribution :-)

I think the standalone repository deserves to be hosted by the ocaml/ organization on Github. An opinion from @agarwal, @amirmc, @avsm, @samoht ?

Whatever we end up doing, just make sure to notify the maintainers of the MELPA package (https://melpa.org/#/caml).

@gasche

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

I would like to clarify that this is not a "request", in the sense that it's perfectly okay for @Chris00 to say no, that he doesn't want to take this responsibility. Then the code would probably stay in the upstream distribution as today -- and we would probably be asking him if he's willing to do reviews when we need them, as today. It was more of an invitation of my part, although indeed an invitation to perform some work.

@gasche

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

@Chris00 the change seems fine to me, would you add a Changes entry?

Make caml-mode an independent project
This was requested by Gabriel Scherer:
#2078 (comment)
Independent version: https://github.com/Chris00/caml-mode

@Chris00 Chris00 force-pushed the Chris00:trunk branch from 936fd21 to 20425ec Dec 17, 2018

@Chris00

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2018

@gasche Changes entry added.

@gasche

gasche approved these changes Dec 17, 2018

Copy link
Member

left a comment

Good to merge once the CI passes. @Chris00, thanks!

@gasche gasche merged commit c612ba0 into ocaml:trunk Jan 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@avsm

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Just catching up on my messages -- it would of course be fine to create a new repository on ocaml/ for this. Please ping me if I can do so @Chris00!

@Chris00

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2019

@avsm Please do!

@avsm

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Sure, what should the repository be called? And is there any connection to [ocaml/tuareg](https://github.com/ocaml/tuareg]? As a non-emacs user, I only have the faintest idea what all this lisp is doing :-)

@avsm

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

(Note: we could call it caml-mode, but I thought that something with "emacs" in the repository title might be clearer)

@nojb

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

caml-mode is standard; e.g. https://github.com/haskell/haskell-mode

@avsm

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Sounds good. I'll create a caml-mode repository for now with @Chris00 and the caml-dev teams having merge rights.

@avsm

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

This has now been setup in https://github.com/ocaml/caml-mode with the same privs as the tuareg repository. Let me know if that needs to be changed.

@andschwa andschwa referenced this pull request Jan 11, 2019

Merged

Update caml recipe #5966

4 of 4 tasks complete
@andschwa

This comment has been minimized.

Copy link

commented Jan 11, 2019

@avsm @Chris00 I updated Melpa in melpa/melpa#5966

@Chris00

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

@andschwa Thanks. If you have time to test further and some points in the checklist do not pass, do not hesitate to open issues for caml-mode.

purcell pushed a commit to melpa/melpa that referenced this pull request Jan 14, 2019

Update caml recipe
In ocaml/ocaml#2182 the Emacs package `caml`
providing `caml-mode` was moved from the `ocaml/ocaml` repository to an
independent repository `ocaml/caml-mode`. This commit updates the Melpa
package to point to the new location.
@andschwa

This comment has been minimized.

Copy link

commented Jan 15, 2019

@Chris00 MELPA fix is merged 😄

@leque leque referenced this pull request May 1, 2019

Merged

update caml-mode.rcp #2702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.